fix(LT-5508): orders and positions are fixed during state validation #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gponomarev-lykke
commented
May 28, 2024
gponomarev-lykke
commented
- orders and positions are fixed during state validation
- the fixed values are then used to create a draft snapshot
- a retry policy added so the "trading data snapshot might be corrupted" fatal errors should be less frequent
- orders and positions are fixed during state validation - the fixed values are then used to create a draft snapshot - a retry policy added so the "trading data snapshot might be corrupted" fatal errors should be less frequent
anokhin-lkk
requested changes
May 28, 2024
|
|
||
| namespace MarginTrading.Backend.Core.Orders | ||
| { | ||
| public interface IOrderReader |
There was a problem hiding this comment.
Maybe we should have a dedicated interface for InMemorySnapshot?
Something like IOrderReader: IOrderReaderBase, where IOrderReaderBase has only 2 required methods?
| { | ||
| var ex = new InvalidOperationException( | ||
| $"The trading data snapshot might be corrupted. The current state of orders and positions is incorrect. Check the dbo.BlobData table for more info: container {LykkeConstants.MtCoreSnapshotBlobContainer}, correlationId {correlationId}"); | ||
| await _log.WriteFatalErrorAsync(nameof(SnapshotService), |
There was a problem hiding this comment.
In case of not valid result we still will have a fatal error I think. Ant this will happen on every retry. Is that expected? And if yes, why?
| "The current state of orders and positions is correct."); | ||
| } | ||
|
|
||
| return validationResult; |
There was a problem hiding this comment.
Also SnapshotStateValidationPolicy will retry on exceprion, but this method will not throw an exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.